PMM-5364 SSL support for Mongo. #528

JiriCtvrtka · 2020-11-20T09:13:22Z

Build: https://github.com/Percona-Lab/pmm-submodules/pull/0
Links to other linked pull requests (optional).
PMM: PMM-5364 SSL support for Mongo. pmm#618
PMM Admin: PMM-5364 SSL support for Mongo. pmm-admin#126
PMM Agent: PMM-5364 SSL support for Mongo. pmm-agent#210

Tests passed.
Feature build pass.
(Re)requested review.
Fix conflicts with target branch.
Update API dependency.
Update jira ticket description if needed.
Attach screenshots/console output to confirm new behavior to jira ticket, if applicable.

codecov · 2020-11-20T09:29:00Z

Codecov Report

Merging #528 (d7e037b) into PMM-2.0 (3139917) will decrease coverage by 0.19%.
The diff coverage is 47.86%.

@@             Coverage Diff             @@
##           PMM-2.0     #528      +/-   ##
===========================================
- Coverage    49.66%   49.46%   -0.20%     
===========================================
  Files          123      123              
  Lines        15453    15547      +94     
===========================================
+ Hits          7674     7690      +16     
- Misses        7067     7148      +81     
+ Partials       712      709       -3

Flag	Coverage Δ
all	`48.87% <47.86%> (-0.20%)`	⬇️
cover	`49.45% <52.97%> (-0.14%)`	⬇️
crosscover	`49.46% <47.86%> (-0.20%)`	⬇️
update	`16.76% <1.19%> (-0.31%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
models/database.go	`58.46% <ø> (ø)`
services/agents/registry.go	`0.00% <0.00%> (ø)`
services/management/grpc/actions_server.go	`0.00% <0.00%> (ø)`
services/management/mongodb.go	`0.00% <0.00%> (ø)`
models/agent_helpers.go	`58.02% <30.00%> (-0.66%)`	⬇️
services/inventory/agents.go	`39.81% <50.00%> (-0.04%)`	⬇️
models/dsn_helpers.go	`72.22% <57.14%> (+11.11%)`	⬆️
models/delimiter.go	`71.42% <66.66%> (ø)`
services/checks/checks.go	`48.13% <66.66%> (+0.16%)`	⬆️
services/agents/mysql.go	`82.60% <71.42%> (-0.90%)`	⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3139917...db45059. Read the comment docs.

AlekSi · 2020-11-26T05:38:33Z

models/agent_model.go

+	TLSSkipVerify                 bool    `reform:"tls_skip_verify"`
+	TLSCertificateKey             string  `reform:"tls_certificate_key"`
+	TLSCertificateKeyFilePassword string  `reform:"tls_certificate_key_file_password"`
+	TLSCaKey                      string  `reform:"tls_ca_key"`


@JiriCtvrtka @BupycHuk I think it might be a time for us to start adding those new properties into a single JSON column

yeah, it might be good reason for that and probably we will need one more task to move other additional fields to single json column.
Other question is should we use the same column for all fields or split them by groups? Using separate columns for each service type will be easier to unmarshal and keep only required field. what do you think?

separate columns for each service type

Sounds good

AlekSi · 2020-11-26T05:40:16Z

We should also update

pmm-managed/models/agent_model.go

Lines 233 to 271 in aa87f50

    
           case QANMongoDBProfilerAgentType, MongoDBExporterType: 
        
           	q := make(url.Values) 
        
           	if dialTimeout != 0 { 
        
           		q.Set("connectTimeoutMS", strconv.Itoa(int(dialTimeout/time.Millisecond))) 
        
           	} 
        
           	// https://docs.mongodb.com/manual/reference/connection-string/ 
        
           	// > If the connection string does not specify a database/ you must specify a slash (/) 
        
           	// between the last host and the question mark (?) that begins the string of options. 
        
           	path := database 
        
           	if database == "" { 
        
           		path = "/" 
        
           	} 
        
           	if s.TLS { 
        
           		q.Add("ssl", "true") 
        
           		if s.TLSSkipVerify { 
        
           			q.Add("tlsInsecure", "true") 
        
           		} 
        
           	} 
        
           	address := socket 
        
           	if socket == "" { 
        
           		address = net.JoinHostPort(host, strconv.Itoa(int(port))) 
        
           	} 
        
           	u := &url.URL{ 
        
           		Scheme:   "mongodb", 
        
           		Host:     address, 
        
           		Path:     path, 
        
           		RawQuery: q.Encode(), 
        
           	} 
        
           	switch { 
        
           	case password != "": 
        
           		u.User = url.UserPassword(username, password) 
        
           	case username != "": 
        
           		u.User = url.User(username) 
        
           	} 
        
           	return u.String()

askomorokhov · 2020-12-24T10:40:51Z

Please resolve conflict

percona-csalguero · 2020-12-24T12:04:04Z

models/agent_model.go

@@ -275,7 +310,10 @@ func (s *Agent) DSN(service *Service, dialTimeout time.Duration, database string
 		case username != "":
 			u.User = url.User(username)
 		}
-		return u.String()
+		dsn := u.String()
+		dsn = strings.Replace(dsn, url.QueryEscape(tdp.Left), tdp.Left, -1)


This could be ReplaceAll()

# Conflicts: # Gopkg.lock

percona-robot · 2020-12-24T22:27:55Z

models/agent_model.go

@@ -169,13 +188,17 @@ func (s *Agent) UnifiedLabels() (map[string]string, error) {
 }

 // DSN returns DSN string for accessing given Service with this Agent (and implicit driver).
-func (s *Agent) DSN(service *Service, dialTimeout time.Duration, database string) string {
+func (s *Agent) DSN(service *Service, dialTimeout time.Duration, database string, tdp *DelimiterPair) string {


🚫 [golangci-lint] _{reported by reviewdog 🐶}
Function 'DSN' has too many statements (96 > 40) (funlen)

percona-robot · 2020-12-24T22:27:55Z

services/inventory/agents_test.go

+			}
+			require.Len(t, actualAgents, 11)
+
+			// TODO: fix protobuf equality https://jira.percona.com/browse/PMM-6743


🚫 [golangci-lint] _{reported by reviewdog 🐶}
services/inventory/agents_test.go:254: Line contains TODO/BUG/FIXME: "TODO: fix protobuf equality https://jira..." (godox)

percona-robot · 2020-12-24T22:27:55Z

models/agent_model_test.go

@@ -110,21 +116,27 @@ func TestAgent(t *testing.T) {
 			ProxySQLExporterType:        "username:s3cur3 p@$$w0r4.@tcp(1.2.3.4:12345)/database?timeout=1s&tls=true",
 			QANMySQLPerfSchemaAgentType: "username:s3cur3 p@$$w0r4.@tcp(1.2.3.4:12345)/database?clientFoundRows=true&parseTime=true&timeout=1s&tls=true",
 			QANMySQLSlowlogAgentType:    "username:s3cur3 p@$$w0r4.@tcp(1.2.3.4:12345)/database?clientFoundRows=true&parseTime=true&timeout=1s&tls=true",
-			MongoDBExporterType:         "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/database?connectTimeoutMS=1000&ssl=true",
-			QANMongoDBProfilerAgentType: "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/database?connectTimeoutMS=1000&ssl=true",
+			MongoDBExporterType:         "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/database?connectTimeoutMS=1000&ssl=true&sslCaFile={{.TextFiles.caFilePlaceholder}}&sslCertificateKeyFile={{.TextFiles.certificateKeyFilePlaceholder}}&sslCertificateKeyFilePassword=pass",


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 282 characters (lll)

percona-robot · 2020-12-24T22:27:56Z

models/agent_model_test.go

-			MongoDBExporterType:         "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/database?connectTimeoutMS=1000&ssl=true",
-			QANMongoDBProfilerAgentType: "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/database?connectTimeoutMS=1000&ssl=true",
+			MongoDBExporterType:         "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/database?connectTimeoutMS=1000&ssl=true&sslCaFile={{.TextFiles.caFilePlaceholder}}&sslCertificateKeyFile={{.TextFiles.certificateKeyFilePlaceholder}}&sslCertificateKeyFilePassword=pass",
+			QANMongoDBProfilerAgentType: "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/database?connectTimeoutMS=1000&ssl=true&sslCaFile={{.TextFiles.caFilePlaceholder}}&sslCertificateKeyFile={{.TextFiles.certificateKeyFilePlaceholder}}&sslCertificateKeyFilePassword=pass",


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 282 characters (lll)

percona-robot · 2020-12-24T22:27:56Z

models/agent_model_test.go


-			assert.Equal(t, "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/?connectTimeoutMS=1000&ssl=true", agent.DSN(service, time.Second, ""))
-			assert.Equal(t, "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/?ssl=true", agent.DSN(service, 0, ""))
+			assert.Equal(t, "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/?connectTimeoutMS=1000&ssl=true&sslCaFile={{.TextFiles.caFilePlaceholder}}&sslCertificateKeyFile={{.TextFiles.certificateKeyFilePlaceholder}}", agent.DSN(service, time.Second, "", nil))


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 268 characters (lll)

percona-robot · 2020-12-24T22:27:56Z

models/dsn_helpers_test.go

+
+		dsn, agent, err := models.FindDSNByServiceIDandPMMAgentID(q, "S4", "PA2", "test")
+		require.NoError(t, err)
+		expected := "mongodb://pmm-user%7B%7B@127.0.0.1:27017/test?connectTimeoutMS=1000&ssl=true&sslCaFile=[[.TextFiles.caFilePlaceholder]]&sslCertificateKeyFile=[[.TextFiles.certificateKeyFilePlaceholder]]&sslCertificateKeyFilePassword=passwordoftls"


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 252 characters (lll)

percona-robot · 2020-12-24T22:27:56Z

services/agents/registry.go

@@ -887,13 +893,18 @@ func (r *Registry) StartPostgreSQLShowIndexAction(ctx context.Context, id, pmmAg
 }

 // StartMongoDBExplainAction starts MongoDB query explain action on pmm-agent.
-func (r *Registry) StartMongoDBExplainAction(ctx context.Context, id, pmmAgentID, dsn, query string) error {
+func (r *Registry) StartMongoDBExplainAction(ctx context.Context, id, pmmAgentID, dsn, query string, files map[string]string, tdp *models.DelimiterPair) error {


🚫 [golangci-lint] _{reported by reviewdog 🐶}
(*Registry).StartMongoDBExplainAction - ctx is unused (unparam)

percona-robot · 2020-12-24T22:27:56Z

services/agents/registry.go

@@ -996,12 +1007,17 @@ func (r *Registry) StartPostgreSQLQuerySelectAction(ctx context.Context, id, pmm
 }

 // StartMongoDBQueryGetParameterAction starts MongoDB getParameter query action on pmm-agent.
-func (r *Registry) StartMongoDBQueryGetParameterAction(ctx context.Context, id, pmmAgentID, dsn string) error {
+func (r *Registry) StartMongoDBQueryGetParameterAction(ctx context.Context, id, pmmAgentID, dsn string, files map[string]string, tdp *models.DelimiterPair) error {


🚫 [golangci-lint] _{reported by reviewdog 🐶}
(*Registry).StartMongoDBQueryGetParameterAction - ctx is unused (unparam)

percona-robot · 2020-12-24T22:27:56Z

services/agents/registry.go

@@ -1017,12 +1033,17 @@ func (r *Registry) StartMongoDBQueryGetParameterAction(ctx context.Context, id,
 }

 // StartMongoDBQueryBuildInfoAction starts MongoDB buildInfo query action on pmm-agent.
-func (r *Registry) StartMongoDBQueryBuildInfoAction(ctx context.Context, id, pmmAgentID, dsn string) error {
+func (r *Registry) StartMongoDBQueryBuildInfoAction(ctx context.Context, id, pmmAgentID, dsn string, files map[string]string, tdp *models.DelimiterPair) error {


🚫 [golangci-lint] _{reported by reviewdog 🐶}
(*Registry).StartMongoDBQueryBuildInfoAction - ctx is unused (unparam)

percona-robot · 2020-12-24T22:27:56Z

services/agents/registry.go

@@ -1038,12 +1059,17 @@ func (r *Registry) StartMongoDBQueryBuildInfoAction(ctx context.Context, id, pmm
 }

 // StartMongoDBQueryGetCmdLineOptsAction starts MongoDB getCmdLineOpts query action on pmm-agent.
-func (r *Registry) StartMongoDBQueryGetCmdLineOptsAction(ctx context.Context, id, pmmAgentID, dsn string) error {
+func (r *Registry) StartMongoDBQueryGetCmdLineOptsAction(ctx context.Context, id, pmmAgentID, dsn string, files map[string]string, tdp *models.DelimiterPair) error {


🚫 [golangci-lint] _{reported by reviewdog 🐶}
(*Registry).StartMongoDBQueryGetCmdLineOptsAction - ctx is unused (unparam)

percona-robot · 2020-12-25T11:16:30Z

models/agent_model_test.go

@@ -110,21 +116,27 @@ func TestAgent(t *testing.T) {
 			ProxySQLExporterType:        "username:s3cur3 p@$$w0r4.@tcp(1.2.3.4:12345)/database?timeout=1s&tls=true",
 			QANMySQLPerfSchemaAgentType: "username:s3cur3 p@$$w0r4.@tcp(1.2.3.4:12345)/database?clientFoundRows=true&parseTime=true&timeout=1s&tls=true",
 			QANMySQLSlowlogAgentType:    "username:s3cur3 p@$$w0r4.@tcp(1.2.3.4:12345)/database?clientFoundRows=true&parseTime=true&timeout=1s&tls=true",
-			MongoDBExporterType:         "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/database?connectTimeoutMS=1000&ssl=true",
-			QANMongoDBProfilerAgentType: "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/database?connectTimeoutMS=1000&ssl=true",
+			MongoDBExporterType:         "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/database?connectTimeoutMS=1000&ssl=true&tlsCaFile={{.TextFiles.caFilePlaceholder}}&tlsCertificateKeyFile={{.TextFiles.certificateKeyFilePlaceholder}}&tlsCertificateKeyFilePassword=pass",


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 282 characters (lll)

percona-robot · 2020-12-25T11:16:30Z

models/agent_model_test.go

-			MongoDBExporterType:         "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/database?connectTimeoutMS=1000&ssl=true",
-			QANMongoDBProfilerAgentType: "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/database?connectTimeoutMS=1000&ssl=true",
+			MongoDBExporterType:         "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/database?connectTimeoutMS=1000&ssl=true&tlsCaFile={{.TextFiles.caFilePlaceholder}}&tlsCertificateKeyFile={{.TextFiles.certificateKeyFilePlaceholder}}&tlsCertificateKeyFilePassword=pass",
+			QANMongoDBProfilerAgentType: "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/database?connectTimeoutMS=1000&ssl=true&tlsCaFile={{.TextFiles.caFilePlaceholder}}&tlsCertificateKeyFile={{.TextFiles.certificateKeyFilePlaceholder}}&tlsCertificateKeyFilePassword=pass",


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 282 characters (lll)

percona-robot · 2020-12-25T11:16:30Z

models/agent_model_test.go


-			assert.Equal(t, "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/?connectTimeoutMS=1000&ssl=true", agent.DSN(service, time.Second, ""))
-			assert.Equal(t, "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/?ssl=true", agent.DSN(service, 0, ""))
+			assert.Equal(t, "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/?connectTimeoutMS=1000&ssl=true&tlsCaFile={{.TextFiles.caFilePlaceholder}}&tlsCertificateKeyFile={{.TextFiles.certificateKeyFilePlaceholder}}", agent.DSN(service, time.Second, "", nil))


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 268 characters (lll)

percona-robot · 2020-12-25T11:16:30Z

models/agent_model_test.go

-			assert.Equal(t, "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/?connectTimeoutMS=1000&ssl=true", agent.DSN(service, time.Second, ""))
-			assert.Equal(t, "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/?ssl=true", agent.DSN(service, 0, ""))
+			assert.Equal(t, "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/?connectTimeoutMS=1000&ssl=true&tlsCaFile={{.TextFiles.caFilePlaceholder}}&tlsCertificateKeyFile={{.TextFiles.certificateKeyFilePlaceholder}}", agent.DSN(service, time.Second, "", nil))
+			assert.Equal(t, "mongodb://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345/?ssl=true&tlsCaFile={{.TextFiles.caFilePlaceholder}}&tlsCertificateKeyFile={{.TextFiles.certificateKeyFilePlaceholder}}", agent.DSN(service, 0, "", nil))


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 236 characters (lll)

percona-robot · 2020-12-25T11:16:31Z

models/dsn_helpers_test.go

+
+		dsn, agent, err := models.FindDSNByServiceIDandPMMAgentID(q, "S4", "PA2", "test")
+		require.NoError(t, err)
+		expected := "mongodb://pmm-user%7B%7B@127.0.0.1:27017/test?connectTimeoutMS=1000&ssl=true&tlsCaFile=[[.TextFiles.caFilePlaceholder]]&tlsCertificateKeyFile=[[.TextFiles.certificateKeyFilePlaceholder]]&tlsCertificateKeyFilePassword=passwordoftls"


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 252 characters (lll)

# Conflicts: # Gopkg.lock

* PMM-5364 Deps. * PMM-5364 Add new fields to add request. * PMM-5364 Deps. * PMM-5364 Deps. * PMM-5364 Add new fields into DB. * PMM-5364 Reform. * PMM-5364 Another fields changes. * PMM-5364 Deps. * PMM-5364 Deps. * PMM-5364 Fields. * PMM-5364 Deps. * PMM-7026 One more revert. * PMM-7026 Deps. * PMM-5364 Changes fields into struct. * PMM-5364 Fix. * PMM-5364 Changes. * PMM-5364 Deps. * PMM-5364 Gen. * PMM-5364 Deps. * PMM-5364 Add TLS keys to MongoDBExplainAction request. * PMM-5364 Remove old code. * PMM-5364 Changes. * PMM-5364 Fix new db fields VM problem. * PMM-5364 Naming changes. * PMM-5364 Changes. * PMM-5364 Deps. * PMM-5364 Deps. * PMM-5364 Fix build. * PMM-5364 Fix test. * PMM-5367 Changes. * PMM-5364 Deps. * PMM-5364 Set default prefix to same. * PMM-5364 Places for paste creating certs. * PMM-5364 Fix test. * PMM-5364 Fix test. * PMM-5364 Make MongoDBOptions struct. * PMM-5364 Fix tests. * PMM-5364 Use text files parameters as .TextFiles. . * PMM-5364 Use text files parameters as .TextFiles . * PMM-5364 Refactoring . * PMM-5364 Fix connection checker. * PMM-5364 Fix tests. * PMM-5364 Fix QAN MongoDB Profiler. * PMM-5364 Fix Explain Action for MongoDB SSL. * PMM-5364 Fix merge conflicts. Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com> Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com>

PMM-5364 Deps.

24f864e

JiriCtvrtka changed the title ~~PMM-5364 Deps.~~ PMM-5364 SSL support for Mongo Nov 20, 2020

JiriCtvrtka changed the title ~~PMM-5364 SSL support for Mongo~~ PMM-5364 SSL support for Mongo. Nov 20, 2020

PMM-5364 Add new fields to add request.

ea95dc8

Jiří Čtvrtka added 11 commits November 23, 2020 11:55

Merge branch 'PMM-2.0' into PMM-5364-ssl-mongo

47a6682

PMM-5364 Deps.

a662d69

PMM-5364 Deps.

fd4f9d8

Merge branch 'PMM-2.0' into PMM-5364-ssl-mongo

75957a9

PMM-5364 Add new fields into DB.

efde7c7

PMM-5364 Reform.

a56f79e

PMM-5364 Another fields changes.

69a3b8b

Merge branch 'PMM-2.0' into PMM-5364-ssl-mongo

9193e30

PMM-5364 Deps.

9496688

PMM-5364 Deps.

f972d65

PMM-5364 Fields.

253409a

AlekSi reviewed Nov 26, 2020

View reviewed changes

Jiří Čtvrtka added 12 commits November 26, 2020 10:17

PMM-5364 Deps.

a4a17b4

PMM-7026 One more revert.

4d66bd5

Merge branch 'PMM-7026-revert-pt-mysql-summary' into PMM-5364-ssl-mongo

af7afe2

PMM-7026 Deps.

8d1b31f

PMM-5364 Fix VM problem.

f82e0c9

PMM-5364 Changes fields into struct.

f6f9faa

PMM-5364 Fix.

41286cf

PMM-5364 Changes.

664dcbc

Merge branch 'PMM-2.0' into PMM-5364-ssl-mongo

34b9394

PMM-5364 Deps.

aa8c5b6

PMM-5364 Gen.

b599a6b

Merge branch 'PMM-2.0' into PMM-5364-ssl-mongo

5011bfa

BupycHuk closed this Dec 23, 2020

BupycHuk reopened this Dec 23, 2020

BupycHuk requested review from BupycHuk, askomorokhov and percona-csalguero December 23, 2020 23:23

BupycHuk marked this pull request as ready for review December 23, 2020 23:24

askomorokhov approved these changes Dec 24, 2020

View reviewed changes

percona-csalguero reviewed Dec 24, 2020

View reviewed changes

percona-csalguero approved these changes Dec 24, 2020

View reviewed changes

BupycHuk added 2 commits December 24, 2020 18:33

PMM-5364 Refactoring .

28b5209

Merge remote-tracking branch 'origin/PMM-2.0' into PMM-5364-ssl-mongo

73d3f0b

# Conflicts: # Gopkg.lock

BupycHuk requested a review from AlekSi December 24, 2020 19:09

BupycHuk added 2 commits December 24, 2020 22:14

Merge remote-tracking branch 'origin/PMM-2.0' into PMM-5364-ssl-mongo

c724bbe

PMM-5364 Fix connection checker.

35bc3c4

percona-robot reviewed Dec 24, 2020

View reviewed changes

PMM-5364 Fix tests.

34277f3

percona-robot reviewed Dec 25, 2020

View reviewed changes

BupycHuk approved these changes Dec 25, 2020

View reviewed changes

BupycHuk requested a review from artemgavrilov December 25, 2020 11:41

artemgavrilov approved these changes Dec 25, 2020

View reviewed changes

AlekSi and others added 6 commits December 26, 2020 15:58

Merge branch 'PMM-2.0' into PMM-5364-ssl-mongo

7362ed0

Merge branch 'PMM-2.0' into PMM-5364-ssl-mongo

d7e037b

PMM-5364 Fix QAN MongoDB Profiler.

3298308

PMM-5364 Fix Explain Action for MongoDB SSL.

fe9163b

Merge remote-tracking branch 'origin/PMM-2.0' into PMM-5364-ssl-mongo

5c66b4b

# Conflicts: # Gopkg.lock

PMM-5364 Fix merge conflicts.

db45059

BupycHuk merged commit 0db06f7 into PMM-2.0 Dec 29, 2020

BupycHuk deleted the PMM-5364-ssl-mongo branch December 29, 2020 09:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PMM-5364 SSL support for Mongo. #528

PMM-5364 SSL support for Mongo. #528

JiriCtvrtka commented Nov 20, 2020 •

edited

Loading

codecov bot commented Nov 20, 2020 •

edited

Loading

AlekSi Nov 26, 2020

BupycHuk Nov 26, 2020

AlekSi Nov 26, 2020

AlekSi commented Nov 26, 2020

askomorokhov commented Dec 24, 2020

percona-csalguero Dec 24, 2020

percona-robot Dec 24, 2020

percona-robot Dec 24, 2020

percona-robot Dec 24, 2020

percona-robot Dec 24, 2020

percona-robot Dec 24, 2020

percona-robot Dec 24, 2020

percona-robot Dec 24, 2020

percona-robot Dec 24, 2020

percona-robot Dec 24, 2020

percona-robot Dec 24, 2020

percona-robot Dec 25, 2020

percona-robot Dec 25, 2020

percona-robot Dec 25, 2020

percona-robot Dec 25, 2020

percona-robot Dec 25, 2020

PMM-5364 SSL support for Mongo. #528

PMM-5364 SSL support for Mongo. #528

Conversation

JiriCtvrtka commented Nov 20, 2020 • edited Loading

codecov bot commented Nov 20, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlekSi commented Nov 26, 2020

askomorokhov commented Dec 24, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JiriCtvrtka commented Nov 20, 2020 •

edited

Loading

codecov bot commented Nov 20, 2020 •

edited

Loading