chore: use Ecto.Type.type to determine db type #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context
```
warning: single-quoted strings represent charlists. Use ~c"" if you indeed want a charlist or use "" instead
│
256 │ defp insert_all_value(_), do: '?'
│ ~
│
└─ lib/snowflex/ecto/connection.ex:256:33
warning: single-quoted strings represent charlists. Use ~c"" if you indeed want a charlist or use "" instead
│
601 │ '?'
│ ~
│
└─ lib/snowflex/ecto/connection.ex:601:5
```
## Context ecto release v1.12.1 introduced a change to the way mappings were return for `Ecto.Enum.mappings/2`. We were relying on this mapping to convert Ecto.Enum to `:string` when creating the database columns. See elixir-ecto/ecto@21c6068#diff-025069044568b480ef6f86f025cb46a7064695e6df1e7008ede689e09a9c7836L317-R318 ## Decision To make this more future proof, use `Ecto.Type.type/1` to handle schema type to database type conversions.
|
Very nice! I like it. |
BruceBC
added a commit
that referenced
this pull request
Aug 19, 2024
…ges-ecto-type Revert "Merge pull request #81"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
ecto release v1.12.1 introduced a change to the way mappings were return for
Ecto.Enum.mappings/2.We were relying on this mapping to convert Ecto.Enum to
:stringwhen creating the database columns.See elixir-ecto/ecto@21c6068#diff-025069044568b480ef6f86f025cb46a7064695e6df1e7008ede689e09a9c7836L317-R318
Decision
To make this more future proof, use
Ecto.Type.type/1to handle schema type to database type conversions.chore: fix single-quoted warning
Context