Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.0.0 fix logger deprecations #80

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

kellyfelkins
Copy link
Contributor

I noticed deprecations warnings on Logger.warn.

@kellyfelkins kellyfelkins changed the base branch from master to v1.0.0 March 6, 2024 23:51
Copy link
Contributor

@notactuallytreyanastasio notactuallytreyanastasio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a note into the changelog because its covering an underlying deprecation that was already around if you were upgrading but LGTM

@kellyfelkins
Copy link
Contributor Author

I would add a note into the changelog because its covering an underlying deprecation that was already around if you were upgrading but LGTM

Good point. What was I thinking?!

@kellyfelkins
Copy link
Contributor Author

We had a discussion about the v1.0.0 branch and how to handle changes to that branch.

https://pepsiecomm.slack.com/archives/C03SPDCC2FJ/p1709769218788049

This small change is consistent with other recent commits on v1.0.0, so I'm going to merge it.

@kellyfelkins kellyfelkins merged commit b6eb28c into v1.0.0 Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants