Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cronokirby/lqt vote plan #5078

Closed

Conversation

cronokirby
Copy link
Contributor

Stacked pr on #5077, please review and merge that first.

This implements all of the bits and bobs necessary to make pcli tx lqt-vote work. I ran a devnet and tested that you can submit votes. The events for voting do get emitted, but there seems to be some issue with either the code or the setup I had in terms of rewards actually being distributed.

To test this pr, spinning up a devnet, or hitting a testnet post #5077 patch would work.

Checklist before requesting a review

  • I have added guiding text to explain how a reviewer should test these changes.

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    Not consensus breaking actually, relative to the protocol branch, or at least, it shouldn't be, since this only touches the client side of things.

@cronokirby cronokirby closed this Feb 8, 2025
@cronokirby
Copy link
Contributor Author

(wrong branch, woops)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant