fix(pd): restore metrics-process emission #5022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In bumping the various metrics-related crates recently, we overlooked that the specific metrics emitted by the `metrics-process` crate had vanished. Bumping the dependency resolves. Updates the pd metrics tests to check for more patterns. These checks were failing on the main branch, specifically the `pd_process_*` patterns. Also refactors the metrics test to use `rstest`, for more granular output.
erwanor
approved these changes
Jan 29, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In bumping the various metrics-related crates recently, we overlooked that the specific metrics emitted by the
metrics-processcrate had vanished. Bumping the dependency resolves.Updates the pd metrics tests to check for more patterns. These checks were failing on the main branch, specifically the
pd_process_*patterns.Also refactors the metrics test to use
rstest, for more granular output.Issue ticket number and link
Refs #5021
Testing and review
I've already confirmed that the new tests failed on main, so CI passing is enough to merge here.
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: