Move rendered book to a versioned path. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eventually, these notes are supposed to become a protocol specification, living on a separate subdomain. It's useful to version specs, so this adds a version to the path, changing `penumbra.zone/XYZ` to `penumbra.zone/VERSION/XYZ`, where `VERSION` is a branch name or git tag. Unfortunately, the firebase cli tools want to deploy an entire site atomically, rather than adding files, so currently, this deployment pipeline can't actually handle tags; only the most recently deployed version will be available. However, the URLs are in place, so the deployment pipeline can be fixed later without redirects. Finally, we add redirects immortalizing the current state of the notes, so that existing links won't break, unless/until the underlying pages change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually, these notes are supposed to become a protocol specification, living
on a separate subdomain. It's useful to version specs, so this adds a version
to the path, changing
penumbra.zone/XYZtopenumbra.zone/VERSION/XYZ,where
VERSIONis a branch name or git tag.Unfortunately, the firebase cli tools want to deploy an entire site atomically,
rather than adding files, so currently, this deployment pipeline can't actually
handle tags; only the most recently deployed version will be available.
However, the URLs are in place, so the deployment pipeline can be fixed later
without redirects.
Finally, we add redirects immortalizing the current state of the notes, so that
existing links won't break, unless/until the underlying pages change.