Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output to pcli to display transaction fees paid #4590

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

zbuc
Copy link
Contributor

@zbuc zbuc commented Jun 11, 2024

Describe your changes

This adds a line to transactions displaying fees paid:

including transaction fee of 13.001mpenumbra...
building transaction [5 actions, 5 proofs]...
finished proving in 1.109 seconds [5 actions, 5 proofs, 3431 bytes]
broadcasting transaction and awaiting confirmation...
transaction broadcast successfully: d1f6b182f04fc34f9437475df841dff8329a938e5949849f50033e5d73c980f5
transaction confirmed and detected: d1f6b182f04fc34f9437475df841dff8329a938e5949849f50033e5d73c980f5 @ height 501989
Swap submitted and batch confirmed!
You will receive outputs of 100test_usd and 0test_atom. Claiming now...
including transaction fee of 1.715mpenumbra...
building transaction [1 actions, 1 proofs]...
finished proving in 0.622 seconds [1 actions, 1 proofs, 591 bytes]
broadcasting transaction and awaiting confirmation...
transaction broadcast successfully: 565c203e3f42223a7989e5d0c3098b60373bd16bcedb99e1127181bb58244553
transaction confirmed and detected: 565c203e3f42223a7989e5d0c3098b60373bd16bcedb99e1127181bb58244553

We might want to call out pre-paid swap claim fees separately.

Issue ticket number and link

Closes #4589

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    pcli only

@zbuc zbuc merged commit 757d42d into main Jun 12, 2024
13 checks passed
@zbuc zbuc deleted the 4589_pcli_fee_display branch June 12, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

pcli should display fees paid
2 participants