Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ViewService RPC method for requesting unbonding tokens #4138

Merged
merged 5 commits into from
Mar 30, 2024

Conversation

jessepinho
Copy link
Contributor

Describe your changes

Create a new ViewService#UnbondingTokensByAddressIndex method.

Issue ticket number and link

Closes #4006

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

This doesn't affect consensus

@jessepinho jessepinho marked this pull request as ready for review March 29, 2024 18:02
@jessepinho jessepinho requested review from erwanor and conorsch March 29, 2024 18:02
@jessepinho jessepinho assigned grod220 and aubrika and unassigned grod220 and aubrika Mar 30, 2024
@jessepinho jessepinho requested review from grod220 and aubrika March 30, 2024 19:33
Copy link
Member

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hdevalence hdevalence merged commit 74a0b46 into main Mar 30, 2024
7 checks passed
@hdevalence hdevalence deleted the jessepinho/unbonding-view-service-methods branch March 30, 2024 23:43
jessepinho added a commit that referenced this pull request Mar 31, 2024
…quest` (#4140)

## Describe your changes
While working on PR #4138, I forgot to include the `address_index` field
in the request for unbonding tokens by address index. This PR fixes
that.

Relevant changes are to the proto file
[here](https://github.com/penumbra-zone/penumbra/pull/4140/files#diff-03b7341d5bf81ab9c8d8542d220d5ba4ae122bd3837531309742b685d7ec1619).

## Issue ticket number and link
#4006 

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > Does not affect consensus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ViewService#unbondingTokens
4 participants