Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: 🙅 mock consensus test that validator definition with invalid auth sig are rejected #4050

Closed
cratelyn opened this issue Mar 19, 2024 · 0 comments · Fixed by #4182
Closed

tests: 🙅 mock consensus test that validator definition with invalid auth sig are rejected #4050

cratelyn opened this issue Mar 19, 2024 · 0 comments · Fixed by #4182
Assignees
@cratelyn
Labels
A-mock-consensus Area: Relates to the mock consensus engine A-staking Area: Design and implementation of staking and delegation A-testing Area: Relates to testing of Penumbra
Milestone
Sprint 4

Comments

@cratelyn
Copy link
Contributor

a validator definition tx that has an invalid authentication signature should be rejected, and not allowed to enter the Defined state. add test coverage for this.
@cratelyn cratelyn added A-staking Area: Design and implementation of staking and delegation A-testing Area: Relates to testing of Penumbra A-mock-consensus Area: Relates to the mock consensus engine labels Mar 19, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra Mar 19, 2024
@cratelyn cratelyn mentioned this issue Mar 19, 2024
Closed
@cratelyn cratelyn self-assigned this Apr 8, 2024
@cratelyn cratelyn added this to the Sprint 4 milestone Apr 8, 2024
@cratelyn cratelyn moved this from Backlog to In progress in Penumbra Apr 8, 2024
@cratelyn cratelyn moved this from In progress to Todo in Penumbra Apr 8, 2024
cratelyn added a commit that referenced this issue Apr 9, 2024
@cratelyn
tests(app): 🙅 app rejects invalid auth signatures
6f9ca77 
fixes #4050. see also #3588.

this introduces a test case that demonstrates that transactions'
validator definition actions must have a valid authentication signature,
or the validator will not be added to the set of known validators.
@cratelyn cratelyn mentioned this issue Apr 9, 2024
Merged
1 task
@cratelyn cratelyn moved this from Todo to In progress in Penumbra Apr 9, 2024
erwanor pushed a commit that referenced this issue Apr 11, 2024
@cratelyn
tests(app): 🙅 app rejects invalid auth signatures (#4182)
d8fcc9d 
fixes #4050. see also #3588.

this introduces a test case that demonstrates that transactions'
validator definition actions must have a valid authentication signature,
or the validator will not be added to the set of known validators.

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > this is a test case.
@github-project-automation github-project-automation bot moved this from In progress to Done in Penumbra Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cratelyn cratelyn

Labels
A-mock-consensus Area: Relates to the mock consensus engine A-staking Area: Design and implementation of staking and delegation A-testing Area: Relates to testing of Penumbra
Projects
Penumbra
Archived in project
Milestone
Sprint 4
Development

Successfully merging a pull request may close this issue.

tests(app): 🙅 app rejects invalid auth signatures penumbra-zone/penumbra
1 participant
@cratelyn