-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: 🔑 add keyring interfaces to TestNode<C>
#3934
Comments
This was referenced Mar 4, 2024
cratelyn
added a commit
that referenced
this issue
Mar 7, 2024
this addresses a few assorted threads from review: https://github.com/penumbra-zone/penumbra/pull/3902/files#r1513620298 https://github.com/penumbra-zone/penumbra/pull/3902/files#r1513615058 https://github.com/penumbra-zone/penumbra/pull/3902/files#r1513613617 https://github.com/penumbra-zone/penumbra/pull/3902/files#r1513617136 see also, #3934. this replaces the `Keys` structure, and defines a new `Keyring` type. this is added to the builder and used by the `with_penumbra_auto_app_state` extension, but it not yet introduced to `TestNode<C>`.
cratelyn
added a commit
that referenced
this issue
Mar 7, 2024
fixes #3816. see #3588. this also addresses part of #3934. this provides extension facilities to the mock consensus test node builder, which allows penumbra-app tests to define a single validator, and subsequently retrieve it from the chain state. see `mock_consensus_can_define_a_genesis_validator`. when run with `--no-capture` enabled, these logs will be visible: ``` 2024-02-28T23:00:43.751036Z DEBUG penumbra_stake::component::stake: adding validator identity to consensus set index, validator: penumbravalid172v76yyqwngcln2dxrs8ht0sjgswer3569yyhezgsz6aj97ecvqqyf3h9h at crates/core/component/stake/src/component/stake.rs:533 in penumbra_stake::component::stake::staking [...] 2024-02-28T23:00:43.776880Z INFO penumbra_app::server::consensus: genesis state is a full configuration at crates/core/app/src/server/consensus.rs:145 2024-02-28T23:00:43.780436Z DEBUG penumbra_app::app: finished committing state, jmt_root: RootHash("46dc0e9561f17eee61a2c13f517036d4d0a4c77c60362cb6cc165083675dcaf7") at crates/core/app/src/app/mod.rs:592 ``` logging facilities are provided so that helper warnings should be given to users that forget to call `with_penumbra_single_validator`, or provide an `AppState` object whose validator list would be overwritten. the `serde_json` dependency is removed from the mock consensus library, it is no longer used. a warning is added to the mock consensus library to note to future contributors that other penumbra dependencies should be avoided in that library. * #3588 * #3816 --------- Co-authored-by: Henry de Valence <hdevalence@penumbralabs.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
see #3588. see #3902 (comment).
in order to test the staking and governance components however, we will need
to provide a keyring, so that the engine can sign blocks.
this should be in service to tests of the staking component that:
The text was updated successfully, but these errors were encountered: