-
Notifications
You must be signed in to change notification settings - Fork 313
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
shielded-pool(ics20): process truncated addresses in packet data (#4962)
## Describe your changes This PR makes sure that truncated addresses are encoded correctly when ICS20 withdrawals are marshaled into fungible packet data. In addition to that, it modifies pcli to (hazardously?) handcraft a return `Address` with an identity clue key and zero diversifier. To test this PR, one can performa IBC roundtrip against a testnet chain with broken bech32m handling (e.g, `grand-1`). ## Issue ticket number and link #4950 ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > CB release branch.
- Loading branch information
Showing
3 changed files
with
23 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters