Skip to content

Commit

Permalink
dex(metrics): set buckets around expected latency region (#4600)
Browse files Browse the repository at this point in the history
## Describe your changes
This re-centers the DEX buckets around the expected latency region

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

(cherry picked from commit 06a08f7)
  • Loading branch information
erwanor authored and conorsch committed Jun 20, 2024
1 parent 10f22d1 commit 322d5be
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
12 changes: 6 additions & 6 deletions crates/core/component/dex/src/component/metrics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,13 @@ pub fn register_metrics() {
// We configure buckets for the DEX routing times manually, in order to ensure
// Prometheus metrics are structured as a Histogram, rather than as a Summary.
// These values may need to be updated over time.
// These values are logarithmically spaced from 5ms to 250ms.
// These values are logarithmically spaced from 5us to 67ms.
const GENERIC_DEX_BUCKETS: &[f64; 16] = &[
0.0005,
0.000792,
0.001256,
0.001991,
0.003155,
0.005,
0.00648985018,
0.00842363108,
Expand All @@ -63,11 +68,6 @@ const GENERIC_DEX_BUCKETS: &[f64; 16] = &[
0.0402798032,
0.05228197763,
0.06786044041,
0.08808081833,
0.11432626298,
0.14839206374,
0.1926084524,
0.250,
];

pub const DEX_PATH_SEARCH_DURATION: &str = "penumbra_dex_path_search_duration_seconds";
Expand Down
3 changes: 1 addition & 2 deletions deployments/compose/metrics.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,4 @@ services:
image: "docker.io/prom/prometheus"
network_mode: host
volumes:
# TODO: this path is not accurate
- /home/conor/src/penumbra/deployments/config/prometheus.yml:/etc/prometheus/prometheus.yml:ro
- "${PWD:?}/../config/prometheus.yml:/etc/prometheus/prometheus.yml:ro"

0 comments on commit 322d5be

Please sign in to comment.