Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Fixed WebAuth api endpoint URI in OpenAPI spec #4039

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

kmahelona
Copy link
Contributor

@kmahelona kmahelona commented Aug 16, 2024

The endpoint isn't correct. Django returns a 404 for /account/webauthn, but /account/authenticators/webauthn seems to work.

Submitting Pull Requests

General

  • Make sure you use semantic commit messages.
    Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
  • All Python code must formatted using Black, and clean from pep8 and isort issues.
  • JavaScript code should adhere to StandardJS.
  • If your changes are significant, please update ChangeLog.rst.
  • If your change is substantial, feel free to add yourself to AUTHORS.

Provider Specifics

In case you add a new provider:

  • Make sure unit tests are available.
  • Add an entry of your provider in test_settings.py::INSTALLED_APPS and docs/installation.rst::INSTALLED_APPS.
  • Add documentation to docs/providers/<provider name>.rst and docs/providers/index.rst Provider Specifics toctree.
  • Add an entry to the list of supported providers over at docs/overview.rst.

The endpoint isn't correct. Django returns a 404 for /account/webauthn, but /account/authenticators/webauthn seems to work.
@pennersr pennersr merged commit 1a35bec into pennersr:main Aug 16, 2024
36 checks passed
@coveralls
Copy link

Coverage Status

coverage: 95.839%. remained the same
when pulling 5a7011e on kmahelona:patch-1
into d6e07b2 on pennersr:main.

@pennersr
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants