Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package.json): upgrade logseq sdk #124

Merged
merged 2 commits into from
Feb 27, 2023
Merged

fix(package.json): upgrade logseq sdk #124

merged 2 commits into from
Feb 27, 2023

Conversation

CharlesChiuGit
Copy link
Contributor

This improves loading time.

pengx17
pengx17 approved these changes Feb 27, 2023
View reviewed changes
Copy link
Owner

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Btw if you want to have a new version published, you should use "fix" in the commit message instead of "chore".

@CharlesChiuGit
Copy link
Contributor Author

CharlesChiuGit commented Feb 27, 2023 •
edited
Loading

LGTM. Btw if you want to have a new version published, you should use "fix" in the commit message instead of "chore".

Noted! tks!

@CharlesChiuGit CharlesChiuGit changed the title chore(package.json): upgrade logseq sdk fix(package.json): upgrade logseq sdk Feb 27, 2023
@pengx17 pengx17 merged commit 4b020da into pengx17:master Feb 27, 2023
@pengx17
Copy link
Owner

pengx17 commented Feb 27, 2023

@CharlesChiuGit it looks like you did not commit changes in lock file. Can you file another pr to fix it?

@CharlesChiuGit
Copy link
Contributor Author

ok, wait a sec!

@CharlesChiuGit CharlesChiuGit mentioned this pull request Feb 27, 2023
Merged
pengx17 pushed a commit that referenced this pull request Feb 27, 2023
@CharlesChiuGit
fix: upgrade logseq sdk ( #124 ) (#125)
78288eb
github-actions bot pushed a commit that referenced this pull request Feb 27, 2023
@semantic-release-bot
chore(release): 2.2.10 [skip ci]
2e2e9bf 
## [2.2.10](v2.2.9...v2.2.10) (2023-02-27)

### Bug Fixes

* **package.json:** upgrade logseq sdk ([#124](#124)) ([4b020da](4b020da))
* upgrade logseq sdk ( [#124](#124) ) ([#125](#125)) ([78288eb](78288eb))
@github-actions
Copy link

🎉 This PR is included in version 2.2.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pengx17 pengx17 pengx17 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CharlesChiuGit @pengx17