Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary support for multi-pass shadertoys. #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cutesthypnotist
Copy link

@cutesthypnotist cutesthypnotist commented Jan 23, 2022

Some issues:

  • Missing material in CRTs' inspector.
  • In CRTs' inspector -> Material -> Shader pass is reverting to default after re-adding material (i.e.: buffer 1 corresponds to pass "1" in shader, buffer 2 -> pass "2", etc.)
  • Materials -> Textures missing from texture slots.
  • Cubemaps don't generate links.
  • Images don't auto-download.

@pema99
Copy link
Owner

pema99 commented Jan 23, 2022

I'll have a look at this some time next week. Did you squash your changes, or did you actually only have 1 commit? I prefer to review larger PRs changeset-by-changeset.

@cutesthypnotist
Copy link
Author

cutesthypnotist commented Jan 24, 2022

I squashed them but yea in the future I'll try not to squash then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants