Make Context's repr debug friendly #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When viewing `Context`s in stack traces/debuggers, it was not obvious which context one was looking at, especially if multiple contexts had values of similar types. With this change, the context name is visible in e.g. Django's debug mode exception page. Since dataclasses are already in use for other classes in htpy, I opted to make the `Context` class a dataclass too. The constructor should be exactly the same before and after this change. Before: ``` <htpy.Context object at 0x7f9af95a16d0>: <<Request: GET '/foo/bar/'> at 0x7f9af5e88410> ``` After: ``` Context(name='request', default=<class 'htpy._NO_DEFAULT'>): <<Request: GET '/foo/bar/'> at 0x7fab5e7a6ad0> ```
|
nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing
Contexts in stack traces/debuggers, it was not obvious which context one was looking at, especially if multiple contexts had values of similar types. With this change, the context name is visible in e.g. Django's debug mode exception page.Since dataclasses are already in use for other classes in htpy, I opted to make the
Contextclass a dataclass too. The constructor should be exactly the same before and after this change.Before:
After: