-
Notifications
You must be signed in to change notification settings - Fork 24
Convert keyword elements correctly #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: very nice, fixing annoyances in html2htpy is really helpful and makes it nicer to use!
bd18b5c
to
3c75efe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated branch to fix conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: very nice, having a html2htpy that works reliable is nice!
I noticed that the
<del>
tag was not converted into htpy'sdel_
correctly. The formatters also can not handle importing python'sdel
keyword and would crash. Ruff would not output anything while Black would output the unformatted code.I fixed these issues by:
div
withdiv_
when converting html using html2htpy.div
is successfully converted todiv_
.@pelme then found out that htpy did not convert the
del_
element to html correctly. So we fixed that as well.del_
element not converting into<del>
correctly.