Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lexer allow T-prefix on local dates #446

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

AllenX2018
Copy link
Contributor

The dateRegex matched localDate with T, we should remove it.

Fix #442

The dateRegex matched localDate with T, we should remove it.

Fix pelletier#442
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #446 into master will decrease coverage by 0.58%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
- Coverage   93.91%   93.32%   -0.59%     
==========================================
  Files          10       10              
  Lines        2448     2158     -290     
==========================================
- Hits         2299     2014     -285     
+ Misses        108      104       -4     
+ Partials       41       40       -1     
Impacted Files Coverage Δ
lexer.go 98.68% <100.00%> (-0.15%) ⬇️
toml.go 73.12% <0.00%> (-2.90%) ⬇️
tomltree_write.go 94.61% <0.00%> (-0.54%) ⬇️
marshal.go 95.86% <0.00%> (-0.47%) ⬇️
parser.go 90.66% <0.00%> (-0.11%) ⬇️
token.go 100.00% <0.00%> (ø)
position.go 100.00% <0.00%> (ø)
localtime.go 100.00% <0.00%> (ø)
keysparsing.go 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e690861...77cd94c. Read the comment docs.

@pelletier
Copy link
Owner

Thanks! Not sure why codecov is detecting so much "coverage change"...

@pelletier pelletier merged commit f9ba082 into pelletier:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lexer allows T-prefix on local dates
2 participants