Support go 1.15 #434
Merged
Support go 1.15 #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #428
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
=======================================
Coverage 93.87% 93.87%
=======================================
Files 10 10
Lines 2434 2434
=======================================
Hits 2285 2285
Misses 108 108
Partials 41 41 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #428
For reference, I decided to remove the textual comparison of the error. This is unreliable between Go versions (as we saw in #428) as well as languages (#226).
If we really want precise checking of errors, we should have our own error types.