-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better support for homogenous lists #377
Conversation
@pelletier Please ignore the first 3 commits, not sure why my old PR commits still show up. Files changes only has changes for this pr |
Thank you for looking at this! I think the behavior of |
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
==========================================
- Coverage 95.34% 94.53% -0.81%
==========================================
Files 10 10
Lines 2318 2379 +61
==========================================
+ Hits 2210 2249 +39
- Misses 68 86 +18
- Partials 40 44 +4
Continue to review full report at Codecov.
|
@pelletier I did not add test cases for homogeneous lists of ints and floats because it picks say, int64 or int32 based on system spec. Hence, test coverage decreases, otherwise all checks have passed. Please review pr and let me know if any changes required |
I think toml integers are always parsed to int64 and toml floats are always parsed to float64, so you might safely ignore the cases for int, int32 and float32 (the tree should not contain these types). Spec: For floats: |
That's great input, thank you. Will make changes |
Issue: #323
Closes #323
Explanation of what this pull request does.
@pelletier
I added logic of GetArray for homogenous lists as getArray func, but need your guidance:
More detailed description of the decisions being made and the reasons why (if the patch is non-trivial).