unmarshal: add strict mode #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a strict mode to the Decoder. It can be enabled with the `Strict` method. In the strict mode, the decoder fails if any fields that were part of the input do not have a corresponding field in the struct.
Codecov Report
@@ Coverage Diff @@
## master #372 +/- ##
==========================================
+ Coverage 95.08% 95.16% +0.07%
==========================================
Files 10 10
Lines 2118 2170 +52
==========================================
+ Hits 2014 2065 +51
- Misses 64 65 +1
Partials 40 40
Continue to review full report at Codecov.
|
pelletier
pushed a commit
that referenced
this pull request
Apr 28, 2020
This PR adds a strict mode to the Decoder. It can be enabled with the `Strict` method. In the strict mode, the decoder fails if any fields that were part of the input do not have a corresponding field in the struct. Fixes #277
|
Merged in d3c92c5 (just added a test case for successful parse in strict mode). Thank you! |
|
awesome thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds strict mode to the Decoder. It can be enabled with the
Strictmethod.In the strict mode, the decoder fails if any fields that were part
of the input do not have a corresponding field in the struct.
The decoder only modifies the visitor state in case strict mode is enabled.
Thus, not forcing unnecessary allocations, when not needed.