Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default values for non-anonymous structs #326

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Support default values for non-anonymous structs #326

merged 1 commit into from
Jan 13, 2020

Conversation

nbedos
Copy link
Contributor

@nbedos nbedos commented Jan 7, 2020

Issue: #274

This adds support for default values on fields of non-anonymous structs. I'm not sure why there was a check for the struct being anonymous prior to calling valueFromTree? I don't see a reason to exclude non-anonymous struct.

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #326 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #326   +/-   ##
======================================
  Coverage    94.6%   94.6%           
======================================
  Files          10      10           
  Lines        2038    2038           
======================================
  Hits         1928    1928           
  Misses         66      66           
  Partials       44      44
Impacted Files Coverage Δ
marshal.go 92.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f6ca41...d2d1376. Read the comment docs.

@pelletier
Copy link
Owner

Thank you for the patch! And sorry for the late reply. I don't recall why that check was there. Tests not breaking is a good enough indication for me that it was not mandatory :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants