Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix float64 truncation error #293

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Conversation

ProfessorMc
Copy link
Contributor

Issue: #289

Fixed it, non-breaking. Updated tests to add the new 64bit float test cases.

@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #293 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
+ Coverage   92.17%   92.19%   +0.02%     
==========================================
  Files           9        9              
  Lines        1892     1897       +5     
==========================================
+ Hits         1744     1749       +5     
  Misses        103      103              
  Partials       45       45
Impacted Files Coverage Δ
tomltree_write.go 86.05% <100%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 781fbae...d4fd03e. Read the comment docs.

@pelletier pelletier changed the title Fix float64 truncation error. Fix float64 truncation error Aug 27, 2019
@pelletier
Copy link
Owner

Thank you very much for your patch! Didn't know math/big could help check for representation precision. Seems to me that this fixes the issue nicely.

@pelletier pelletier closed this Aug 27, 2019
@pelletier pelletier reopened this Aug 27, 2019
@pelletier pelletier merged commit 3ded2e0 into pelletier:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants