Support time.duration #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
+ Coverage 89.11% 89.16% +0.04%
==========================================
Files 9 9
Lines 1663 1670 +7
==========================================
+ Hits 1482 1489 +7
Misses 129 129
Partials 52 52
Continue to review full report at Codecov.
|
|
Hi @pelletier, could you please check these changes and give some feedback? |
pelletier
approved these changes
Nov 12, 2018
There was a problem hiding this comment.
@asenyshyn thanks for the ping. That completely fell through the cracks!
Does not seem to be breaking existing behavior. Looks good to me!
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to add support for time.Duration after discussion in #237