Allow to marshal pointer to struct and map #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 89.11% 89.14% +0.03%
==========================================
Files 9 9
Lines 1663 1668 +5
==========================================
+ Hits 1482 1487 +5
Misses 129 129
Partials 52 52
Continue to review full report at Codecov.
|
pelletier
approved these changes
Nov 19, 2018
|
No problem, thank you for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have nothing much to add here. I need to be able to marshal pointer to struct or map, thus I extended validation in Encoder marshal method. As far as I can see further call of valueToTree supports both pointer and map.