Add Encoder/Decoder types #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a21193 to
4874ef9
Compare
|
@pelletier @moorereason feedback? |
pelletier
reviewed
Oct 22, 2017
3f8dafb to
44099d4
Compare
|
I moved the new types into I also made sure the package global |
|
I will squash once you approve 🙂 |
|
@robertgzr Seems like you have some conflicts :) Don't worry about squashing, I always squash and merge. |
|
@pelletier I just wanted to make it easier to look at individual commits but it seems Github doesn't like the first one that deletes |
|
Go for it! |
44099d4 to
3df5a94
Compare
Usage is similar to the stdlibs JSON encoder/decoder but I tried to leave the general structure of the code the same. Main motivation was to support encoding/decoding options to allow encoding string-type map keys as quoted TOML keys. This was implemented on the Encoder with QuoteMapKeys(bool). > The TOML spec supports using UTF-8 strings as keys. > https://github.com/toml-lang/toml/blob/master/versions/en/toml-v0.4.0.md#table
3df5a94 to
d32b181
Compare
|
Thank you very much for that contribution @robertgzr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage is similar to the stdlibs JSON encoder/decoder but I tried to
leave the general structure of the code the same.
Main motivation was to support encoding/decoding options to allow
encoding string-type map keys as quoted TOML keys.
This was implemented on the Encoder with QuoteMapKeys(bool).
Replaces #190