Rewrite TomlTree encoding #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes:
string,int64,uint64,float64,bool,time.Time,[] of any of this list; and those for intermediate nodes:*tomlValue,*tomlTree,[]*TomlTree. This allows for a great deal of simplification in the encoding code, as well as saner logic. The caveat is thatTreeFromMap()currently does not perform any sanitization. I'm planning on implementing that in subsequent changes, but in the meantime the tree should be properly constructed usingSet().tomltree_conversions*.gofiles are nowtomltree_write*.go.tree.WriteTo(io.Writer) (int64, error)is now available, for all the encoding needs.@tgulacsi this is loosely based on your #123. Thanks for the work and support!