Move core metrics registration into a new metriken-core crate #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of the issue with how metriken is designed is that there can only be a single copy of metriken within the whole dependency tree. This is not great since it makes a major version update rather painful. The solution I am adding here is to extract the core trait and linker shenanigans into a separate metriken-core crate. The goal here is that the metriken-core crate will never have a major version bump while the metriken crate can have new versions when necessary. To further that goal, I have made sure that the metriken-core API exposes no types from any other crate.
brayniac
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the issue with how metriken is designed is that there can only be a single copy of metriken within the whole dependency tree. This is not great since it makes a major version update rather painful.
The solution I am adding here is to extract the core trait and linker shenanigans into a separate metriken-core crate. The goal here is that the metriken-core crate will never have a major version bump while the metriken crate can have new versions when necessary.
To further that goal, I have made sure that the metriken-core API exposes no types from any other crate.