Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate and support Python 3.6+ #1

Merged
merged 7 commits into from
Apr 5, 2023

Conversation

wombelix
Copy link
Collaborator

Related Issue: getpelican/pelican-plugins#1333

@justinmayer I performed the migration steps in March 2021, please let me know if anything in the template I used at that time is now outdated and you want to be changed before merging. I use this version in my personal blog since then without issues.

@wombelix
Copy link
Collaborator Author

Update pre-commit to the latest version, got error ImportError: cannot import name '_unicodefun' from 'click' with the old one from last march.

@justinmayer justinmayer merged commit 4a4f97d into pelican-plugins:migrate Apr 5, 2023
@justinmayer
Copy link
Contributor

Hi Dominik. Many thanks for work on migrating this plugin, and sincere apologies for the delay in getting it merged.

I made some follow-up changes due to configuration drift, and pushing those commits somehow seems to have closed this PR, I think perhaps because you submitted the PR from your fork as opposed to the existing migrate branch here on this remote, potentially causing confusion since both remotes share the same branch name. I will submit a new PR containing the additional commits so you can review them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants