Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Abiotic Factor #4

Merged
merged 4 commits into from
May 8, 2024
Merged

Conversation

RStivanson
Copy link
Contributor

Description

Adds basic support for Abiotic Factor using Proton.

Also added a link to the official game server wiki in the README. It's a repository on (what appears to be) one of the developer's GitHub account, and was advertised in the official steam release announcement.

Note: that the install script downloads the sidecar INI file as the server does not create one by default (just uses the default values if the file doesn't exist). I'm adding the INI alongside such that it is pre-populated in the correct location for the end-user.

Closes pelican-eggs/eggs#2926

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:

New egg Submissions

  1. Does your submission pass tests (server is connectable)?
  2. Does your egg use a custom docker image?
    • Have you tried to use a generic image?
    • Did you PR the necessary changes to make it work?
  3. Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  6. The egg was exported from the panel

@RStivanson RStivanson changed the title initial copy Add Abiotic Factor May 4, 2024
@RStivanson RStivanson mentioned this pull request May 4, 2024
13 tasks
"env_variable": "QUERY_PORT",
"default_value": "27015",
"user_viewable": true,
"user_editable": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A port can never be user editable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

"default_value": "6",
"user_viewable": true,
"user_editable": true,
"rules": "required|numeric|min:1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe validate here with a between?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a max of 32.

@RStivanson RStivanson requested a review from QuintenQVD0 May 8, 2024 14:10
Copy link
Contributor

@QuintenQVD0 QuintenQVD0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Egg Request]: Abiotic Factor
2 participants