-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Abiotic Factor #4
Conversation
"env_variable": "QUERY_PORT", | ||
"default_value": "27015", | ||
"user_viewable": true, | ||
"user_editable": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A port can never be user editable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
"default_value": "6", | ||
"user_viewable": true, | ||
"user_editable": true, | ||
"rules": "required|numeric|min:1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe validate here with a between?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a max of 32.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you.
Description
Adds basic support for Abiotic Factor using Proton.
Also added a link to the official game server wiki in the README. It's a repository on (what appears to be) one of the developer's GitHub account, and was advertised in the official steam release announcement.
Note: that the install script downloads the sidecar INI file as the server does not create one by default (just uses the default values if the file doesn't exist). I'm adding the INI alongside such that it is pre-populated in the correct location for the end-user.
Closes pelican-eggs/eggs#2926
Checklist for all submissions
New egg Submissions