remove geo_point properties deprecated in 2.3 or 2.4 #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, I didn't realize these were deprecated in 2.3/2.4, that makes the upgrade to ES5 a lot simpler. Connects pelias/pelias#461 |
orangejulius
approved these changes
Sep 27, 2018
|
It's quite difficult to enable the deprecation log in ES 2.x (it only logs at the debug level, and the debug level is very noisy), but I took a look and these deprecation warnings were the only ones there. Therefore it looks like, as far as properties in the schema go, this is indeed the only change required for ES5 compatibility! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove geo_point properties deprecated in 2.3 or 2.4