Skip to content

Commit

Permalink
fix(layer aliases): Remove duplicate continent entry
Browse files Browse the repository at this point in the history
For some time, apparently, there have been two `continent` entries in
the `layer_alias` default configuration. Overall, this hasn't had any
significant negative effect, since this list is mostly used in places
that eventually deduplicate it.

Worst case, some Elasticsearch filters and error messages have listed
the continent layer twice, which is redundant but not going to break
anything.

It's obviously better fixed though, and makes writing some API unit
tests a bit simpler :)
  • Loading branch information
orangejulius committed Apr 26, 2021
1 parent 2bdcc85 commit ba67e73
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions config/defaults.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"whosonfirst": [
"continent", "empire", "country", "dependency", "macroregion", "region", "locality",
"localadmin", "macrocounty", "county", "macrohood", "borough", "neighbourhood",
"microhood", "disputed", "venue", "postalcode", "continent", "ocean", "marinearea"
"microhood", "disputed", "venue", "postalcode", "ocean", "marinearea"
]
},
"source_aliases": {
Expand All @@ -63,7 +63,7 @@
"coarse": [
"continent", "empire", "country", "dependency", "macroregion", "region", "locality",
"localadmin", "macrocounty", "county", "macrohood", "borough", "neighbourhood",
"microhood", "disputed", "postalcode", "continent", "ocean", "marinearea"
"microhood", "disputed", "postalcode", "ocean", "marinearea"
]
}
}
Expand Down
4 changes: 2 additions & 2 deletions test/expected-deep.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"whosonfirst": [
"continent", "empire", "country", "dependency", "macroregion", "region", "locality",
"localadmin", "macrocounty", "county", "macrohood", "borough", "neighbourhood",
"microhood", "disputed", "venue", "postalcode", "continent", "ocean", "marinearea"
"microhood", "disputed", "venue", "postalcode", "ocean", "marinearea"
]
},
"source_aliases": {
Expand All @@ -68,7 +68,7 @@
"coarse": [
"continent", "empire", "country", "dependency", "macroregion", "region", "locality",
"localadmin", "macrocounty", "county", "macrohood", "borough", "neighbourhood",
"microhood", "disputed", "postalcode", "continent", "ocean", "marinearea"
"microhood", "disputed", "postalcode", "ocean", "marinearea"
]
}
}
Expand Down

0 comments on commit ba67e73

Please sign in to comment.