forked from liferay/liferay-portal
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lps 194957 blueprint collection provider can return model classes2 #13
Open
peerkar
wants to merge
523
commits into
master
Choose a base branch
from
LPS-194957_BlueprintCollectionProviderCanReturnModelClasses2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lps 194957 blueprint collection provider can return model classes2 #13
peerkar
wants to merge
523
commits into
master
from
LPS-194957_BlueprintCollectionProviderCanReturnModelClasses2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci:test:sf |
f1200d4
to
b8660cf
Compare
…t char replacement. Allowing the portal to retrieve files with names including '%2B and '%25' keeping the original functionality of using '+' to identify ' '.
…n-root context environments.
…localization map from the LAR file
…log API (yaml file)
There is no need to check for empty values as the field is required
Check for empty label values and set fallback to the field name
probably wasn't intentional. HashMap should suffice.
the ConfigurationProvider already handles this for us. When we compute the Configuration for an Instance, it will return the System Configuration if the Instance Configuration does not exist.
instantiate it if it does not
rely on lazy-loading to load the cache
keep attempting the lazy-load over and over in this case
…ctionProvider an abstract base class
…nd a Journal Article collection providers
… Article collection provider in case only Journal Articles are defined as the searchable type
b8660cf
to
fd9448e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.