Support css-loader v2 #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
css-loader version 2 uses a placeholder constant and a single require for url resources. Something about this causes the dependency resolution to only be called once. This means that there will be more instances of the placeholder string in the content than are in the extractedDependencyContent array. This is fixed by explicitly tying the dependencies to a unique instance of the placeholder string.
|
I'm having this same problem with the |
|
I tested it too, and it works. Would be nice if you could fix the Build: https://travis-ci.com/github/peerigon/extract-loader/jobs/205442098 and merge it into master! I don't want to rely on my fork, and I don't want to step back to css-loader@1.0.1 |
wokung
added a commit
to wokung/extract-loader
that referenced
this pull request
Apr 9, 2020
|
This issue was fixed with #83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to #54 (webpack-contrib/css-loader#864) where, when using css-loader version 2, resources are incorrectly replaced.
I don't know enough about how all the internals of webpack work to fully explain the issue, but the gist of the problem is that css-loader version 2 uses a placeholder constant and a single require for url resources. Something about this causes the dependency resolution to only be called once. This means that there will be more instances of the placeholder string in the content than are in the extractedDependencyContent array.
This fixes that by explicitly tying the dependencies to a unique instance of the placeholder string.