Skip to content

Resolve lintr warnings #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 20, 2023
Merged

Resolve lintr warnings #65

merged 13 commits into from
Jul 20, 2023

Conversation

pdil
Copy link
Owner

@pdil pdil commented Dec 10, 2022 •
edited
Loading

  • This PR will contain all changes to remove all warnings and notes generated by lintr
  • Once the PR is ready to be merged, all lintr warnings should have been resolved or suppressed
  • Going forward any new PRs should seek to prevent any lintr warnings

fixes #63

@pdil pdil added the tech Technical issues and pull requests not directly related to usmap functionality label Dec 10, 2022
@pdil pdil self-assigned this Dec 10, 2022
@pdil pdil added this to the v1.0.0 milestone Dec 10, 2022
@pdil pdil changed the title Resolve lintr warnings WIP - Resolve lintr warnings Dec 10, 2022
@pdil
Copy link
Owner Author

pdil commented Dec 11, 2022 •
edited
Loading

lintr is failing due to invalid SARIF file (see r-lib/lintr#1836 and r-lib/lintr#1837) since all issues have been resolved

@pdil pdil marked this pull request as draft June 9, 2023 02:15
@pdil pdil changed the title WIP - Resolve lintr warnings Resolve lintr warnings Jun 9, 2023
@pdil
Copy link
Owner Author

pdil commented Jul 19, 2023

Per r-lib/lintr#1476 (comment) lintr has been updated with the SARIF fix mentioned above

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 19, 2023
View reviewed changes
@pdil pdil marked this pull request as ready for review July 19, 2023 20:32
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 19, 2023
View reviewed changes
@pdil pdil merged commit 2768d35 into master Jul 20, 2023
@pdil pdil deleted the bugfix/resolve-lintr-warnings branch July 20, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pdil pdil

Labels
tech Technical issues and pull requests not directly related to usmap functionality
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Resolve lintr code scanning warnings
1 participant
@pdil