Separate aws-keychain.keychain from login.keychain #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the login keychain is used, which tends to be always unlocked. This sets the default to a keychain called 'Amazon AWS', which is created if it's missing in add.
|
I dunno, I'd probably just put that in a separate script for migrating from v1. Shame to bulk up the main script so much. |
|
I considered that, then I thought about helping N people upgrade from v2 to v3, and figured it's best to bundle it. It's basically a self-contained function that can be trivially removed in a future version. It also re-invokes Edited: |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands upon and closes #14 by @lox;
Uses (and auto-creates) a separate
aws-keychain.keychainwhich can be overridden byAWS_KEYCHAIN_FILE. This keeps credentials out of the always-unlockedlogin.keychain, and allows fine-tuning of auto-lock parameters. Newly created keychains seem to default to auto-lock after 5 minutes and when sleeping.Provides
aws-keychain migrateto move items from the old keychain to the new one. Both source and destination can be specified in the environment (so e.g. reverse migration is possible), but the defaults are sensible and respect customAWS_KEYCHAIN_FILE.Compared to #14,
AWS_KEYCHAIN_FILEdefaults toaws-keychain.keychainrather thanAmazon AWS.keychainso that the name matches the tool and contains no spaces.