FIX: missing and extra device fills #548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- alarm shapes auto-fill device now - avoid overwriting user-set devices
|
This PR will need to expand in scope a bit: I can't test it properly without adding some small features that I want to add anyway. The issue is that it's not currently possible to apply subdevices to widgets if they are not sourced from happi. |
|
This PR is no longer relevant, I will close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
https://jira.slac.stanford.edu/browse/LCLSPC-653
How Has This Been Tested?
I will add a test prior to asking for reviewers
Where Has This Been Documented?
Comments, and later, release notes