DEV/MNT: migrate to latest standards with pyproject.toml [LCLSPC-603]

[tangkong]

Description

runs pcds-python-migration-tools on this repository

Motivation and Context

Prep for the hackathon, clean up this repo

How Has This Been Tested?

Hopefully with GHA soon

Where Has This Been Documented?

This PR

[klauer]

First I've noticed it:

The following exceptions are kept for compatibility with previous versions; starting from Python 3.3, they are aliases of [OSError](https://docs.python.org/3/library/exceptions.html#OSError).

exception EnvironmentError

https://docs.python.org/3/library/exceptions.html#EnvironmentError

[tangkong]

I give up on the tests for now. I think for the sake of allowing people to contribute to typhos (and not having to deal with pyupgrade merge conflicts) I'll make a followup issue for the troublesome tests and skip them. Maybe I'll get local gha working some time soon.

[ZLLentz]

I think that's a good call.
To be clear, this issue only happens on the CI, not when running the tests locally?

[tangkong]

I think that's a good call. To be clear, this issue only happens on the CI, not when running the tests locally?

Yep, all the tests pass for me locally. 😢

[ZLLentz]

I wonder if there's any way to tell if we're on the CI so we can at least make sure they all run locally. A generic @skip_on_ci decorator could be useful.

I'll review tomorrow.

[ZLLentz]

Do we need to merge before we can set the required/not required settings?

[klauer]

No, that can be set right now: https://github.com/pcdshub/pcds-python-migration-tools/blob/master/update_github_settings.py

[tangkong]

huh we didn't have branch protection rules already set up for typhos?...

[klauer]

Branch protection set with the above-mentioned script.

Merging because our required tests are passing and it's Friday and there's no one here to stop me.