Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Img401 #99

Merged
merged 13 commits into from
Jun 30, 2022
Merged

Img401 #99

merged 13 commits into from
Jun 30, 2022

Conversation

jyin999
Copy link
Contributor

@jyin999 jyin999 commented Apr 1, 2022

Description

Motivation and Context

How Has This Been Tested?

Where Has This Been Documented?

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to Always Newest version (Library, *)
  • Committed with pre-commit or ran pre-commit run --all-files

@jyin999 jyin999 requested a review from ghalym April 1, 2022 21:24
L2SIVacuum/POUs/Functions/Gauges/FB_IMG401.TcPOU Outdated Show resolved Hide resolved
L2SIVacuum/POUs/Functions/Gauges/FB_IMG401.TcPOU Outdated Show resolved Hide resolved
@jyin999 jyin999 requested review from Mbosum and ghalym April 5, 2022 17:10
@jyin999
Copy link
Contributor Author

jyin999 commented Apr 5, 2022

For gauge "Valid" state, add checking of "i_HV_ON" and "q_xHV_DIS". It is to solve the issue when cable is disconnected, Beckhoff readings are jumping between 0 and small noise voltage, it cause gauge state changes between "Valid" and "GaugDisc". Then PLC sends out a lot logger messages.

Add the code below to distinguish gauge "Off" state from gauge "OOR" state:

"ELSIF rV <= vDisconnected AND NOT IG.i_xHV_ON and NOT IG.q_xHV_DIS THEN
IG.eState := Off;
IG.rPRESS := cDefaultPressure;"

@jyin999 jyin999 closed this Apr 5, 2022
@jyin999 jyin999 reopened this Apr 5, 2022
Signed-off-by: jyin999 <jyin@slac.stanford.edu>
@jyin999 jyin999 merged commit c9fae6c into pcdshub:master Jun 30, 2022
@jyin999 jyin999 deleted the IMG401 branch August 1, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants