Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vat590 #93

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Vat590 #93

merged 2 commits into from
Mar 28, 2022

Conversation

jyin999
Copy link
Contributor

@jyin999 jyin999 commented Mar 25, 2022

VAT590 function is tested on LAMP and ready to merge into vacuum library

Motivation and Context

How Has This Been Tested?

Where Has This Been Documented?

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to Always Newest version (Library, *)
  • Committed with pre-commit or ran pre-commit run --all-files

@jyin999 jyin999 requested review from ghalym and janezg-SLAC March 25, 2022 21:50
@@ -90,5 +90,19 @@ END_VAR
<ST><![CDATA[This^.iTermBits := TermBits;]]></ST>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you change FB_972 by mistake?

Copy link
Contributor

@janezg-SLAC janezg-SLAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a comment on FB_972 changes.

@jyin999 jyin999 merged commit 0ecdade into pcdshub:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants