Add function block FB_VRC_NC_ClsLS for ChemRIXS single limit switch v… #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghalym
requested changes
Sep 30, 2021
| IF NOT iq_stValve.i_xClsLS AND iq_stValve.q_xOPN_DO THEN | ||
| iq_stValve.eState:=OPEN; | ||
| ELSIF NOT iq_stValve.i_xClsLS AND NOT iq_stValve.q_xOPN_DO THEN | ||
| iq_stValve.eState:=OPEN_F; |
There was a problem hiding this comment.
Not Sure we can have OPEN_F state. This might be an invalid state. We are not reading the CLS_LS but we are not opening it either. The cable might be unplugged?!
There was a problem hiding this comment.
Good point. The valve cannot force open. It should be invalid state.
ghalym
approved these changes
Sep 30, 2021
slactjohnson
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alve.