Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue # 20 and #22 #24

Merged
merged 4 commits into from
Mar 26, 2020
Merged

Issue # 20 and #22 #24

merged 4 commits into from
Mar 26, 2020

Conversation

ghalym
Copy link
Collaborator

@ghalym ghalym commented Mar 18, 2020

Issue#20 : Ion Pumps use own pressure reading after turning on, also added a method for AutoOn. user program to invoke the method. Also available through pragma.
Issue#22, Update MKS 909 Hot Cathode POU with logging and all other upgrades.

ghalym added 2 commits March 18, 2020 15:37
Issue#20 : Ion Pumps use own pressure reading after turning on, also added a method for AutoOn. user program to invoke the method.

Issue#22, Update MKS 909 Hot Cathode POU with logging and all other upgrades.
@slacAWallace
Copy link
Contributor

Maggie, you should use a more descriptive title and include the issues in the text so they automatically link.

@ghalym
Copy link
Collaborator Author

ghalym commented Mar 18, 2020

I had them in the commits.
I will include them in the PR.

Copy link
Contributor

@slacAWallace slacAWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of the gauge messages are a bit too severe. Otherwise looks good.

L2SIVacuum/POUs/Functions/Gauges/FB_MKS909.TcPOU Outdated Show resolved Hide resolved
@ghalym ghalym requested a review from slacAWallace March 23, 2020 20:55
@ghalym ghalym merged commit f97f179 into pcdshub:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants