Stats2 #146
Stats2 #146
Conversation
|
Looks okay to me! @KaushikMalapati are we removing mean and stdev PVs for M1K1 pitch as well ? |
They are still being calculated by fbMR1K1PiPosDiffStats in FB_Stats |
|
This is running and seems to be working |
| @@ -68,7 +68,7 @@ tonNewGpiMove( | |||
| PT:=T#15s, | |||
| ); | |||
|
|
|||
| fMpiEncoderPosDiff := M6.nEncoderCount - (M6.Axis.NcToPlc.SetPos - M6.stAxisParameters.fEncOffset) / 0.004505; | |||
| fMpiEncoderPosDiff := ((UDINT_TO_LREAL(M6.nEncoderCount) * 0.004505) - (M6.Axis.NcToPlc.SetPos - M6.stAxisParameters.fEncOffset)) * 1000; | |||
There was a problem hiding this comment.
Why are we scaling the diff value by 1000? @KaushikMalapati
There was a problem hiding this comment.
Georgi asked for units of nanoradians for convenience
There was a problem hiding this comment.
I see, that checks out, I see scaled to user from encoder counts minus set position = urad * 1000 = nrad.
|
@nrwslac could you approve again? I just released a new version of ads-ioc that archives another motor record field I want to use in a grafana alert |
Description
Removing MR1K1:BEND:ENC:PITCH: pvs from FB_RMSWatch
Changed the units for MR1K1:BEND:MMS:PITCH:ENCDIFF:STATS:RMS_RBV, SP1K1:MONO:MMS:M_PI:ENCDIFF:STATS:RMS_RBV and SP1K1:MONO:MMS:G_PI:ENCDIFF:STATS:RMS_RBV to be in nrad instead of urad (I mistakenly said urad in my commit message)
Motivation and Context
https://jira.slac.stanford.edu/browse/ECS-6173
How Has This Been Tested?
Not tested yet
Where Has This Been Documented?
Screenshots (if appropriate):
Pre-merge checklist
Always Newestpre-commit(alternativelypre-commit run --all-files)