K1 Optics encdiff stats #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All three are running with a buffer of a thousand right now, but do you think there is any benefit to them being larger? |
|
Left this running over night and it never exceeded cycle time. |
nrwslac
reviewed
Jan 25, 2025
nrwslac
reviewed
Jan 25, 2025
KaushikMalapati
commented
Jan 25, 2025
| );*) | ||
| ); | ||
|
|
||
| fMR1K1PiEncoderPosDiff := M16.nEncoderCount - (M16.Axis.NcToPlc.SetPos - M16.stAxisParameters.fEncOffset) / 0.00244; |
There was a problem hiding this comment.
@nrwslac can you double check with me that I am using the correct denominator here before I merge? I got it from the Scaling Factor Numerator for the stage
There was a problem hiding this comment.
Looks good. Confirmed 0.00244 is the MR1K1 Bend Pitch Scaling Numerator.
I thought I might get lower RMS over a longer interval; it wasnt the case, so no, I think 1000 is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed m_pi buffer size to 1000 and uncommented
Added encdiff stats for M1K1
Motivation and Context
https://jira.slac.stanford.edu/browse/ECS-6173
How Has This Been Tested?
Running on rixs-optics, haven't seen any errors related to going over cycle time
Where Has This Been Documented?
Screenshots (if appropriate):
Pre-merge checklist
Always Newestpre-commit(alternativelypre-commit run --all-files)