Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: standardize mirror RTD implementations #130

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

nrwslac
Copy link
Contributor

@nrwslac nrwslac commented Oct 25, 2024

Description

  • update MR3/4K2 mirror RTD implementations to match TMO.

Motivation and Context

  • KBO mirrors using the same pcds device so updating them all at once makes sense.

How Has This Been Tested?

running on PLC, tested by viewing PCDS device typhos screen.

Where Has This Been Documented?

https://jira.slac.stanford.edu/browse/ECS-6705

Screenshots (if appropriate):

KBs-mirror-temp

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@nrwslac nrwslac marked this pull request as ready for review November 6, 2024 00:47
@nrwslac nrwslac requested review from jyotiphy and ghalym November 6, 2024 00:49
ghalym
ghalym previously approved these changes Nov 8, 2024
@nrwslac nrwslac requested a review from ghalym November 12, 2024 21:30
@nrwslac
Copy link
Contributor Author

nrwslac commented Nov 12, 2024

Resolved merge conflict, need review and approval. @ghalym

@KaushikMalapati
Copy link
Contributor

@nrwslac , do you want to tack on the change to SL1K2 from https://jira.slac.stanford.edu/browse/ECS-6745 in this pr? I don't think I can suggest the change since that file wasn't edited in branch, but the change would be in

{attribute 'pytmc' :='pv: SL1K2:EXIT:FWM:1'}

alongside an ioc rebuild.

@nrwslac
Copy link
Contributor Author

nrwslac commented Nov 13, 2024

@KaushikMalapati yea, I can add that to this PR.

@nrwslac
Copy link
Contributor Author

nrwslac commented Nov 19, 2024

I'll fix the SL1K2 pv name in the next pull request.

Copy link
Contributor

@jyotiphy jyotiphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@nrwslac nrwslac merged commit cfa589f into pcdshub:master Nov 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants