-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: standardize mirror RTD implementations #130
Conversation
Resolved merge conflict, need review and approval. @ghalym |
@nrwslac , do you want to tack on the change to SL1K2 from https://jira.slac.stanford.edu/browse/ECS-6745 in this pr? I don't think I can suggest the change since that file wasn't edited in branch, but the change would be in
alongside an ioc rebuild. |
@KaushikMalapati yea, I can add that to this PR. |
I'll fix the SL1K2 pv name in the next pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Description
Motivation and Context
How Has This Been Tested?
running on PLC, tested by viewing PCDS device typhos screen.
Where Has This Been Documented?
https://jira.slac.stanford.edu/browse/ECS-6705
Screenshots (if appropriate):
Pre-merge checklist
Always Newest
pre-commit
(alternativelypre-commit run --all-files
)