Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating SL1K2 gap motor and MR1K2 #121

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

jyotiphy
Copy link
Contributor

Description

*Updating/Tuning SL1K2 gap motor parameters to get better precision
*Fixing SL1K2 gap motor offset (sign change -75 instead of previous +75)
*Forcing limit switches of MR1K2 pitch motor as these aren't installed anymore

How Has This Been Tested?

Yes, tested and working fine

Where Has This Been Documented?

[(https://jira.slac.stanford.edu/browse/ECS-5297)]
[(https://jira.slac.stanford.edu/browse/ECS-5316)]

Screenshots (if appropriate):

Pre-merge checklist

  • [ x] Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • [x ] Code committed with pre-commit (alternatively pre-commit run --all-files)

NSLentz
NSLentz previously approved these changes May 14, 2024
Copy link

@NSLentz NSLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thank you!

Copy link

@NSLentz NSLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank your for re-running pre-commit

@jyotiphy jyotiphy merged commit 6b4dd0b into pcdshub:master May 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants