Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: SL1K2 GAp motion monitoring parameters. #120

Merged
merged 1 commit into from
May 13, 2024

Conversation

ghalym
Copy link
Collaborator

@ghalym ghalym commented May 8, 2024

Description

Motivation and Context

How Has This Been Tested?

Where Has This Been Documented?

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@ghalym ghalym requested review from jyotiphy and patoppermann May 8, 2024 21:27
Copy link
Contributor

@jyotiphy jyotiphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghalym I'm not sure why we have changes in other stages (or maybe no changes...as it's not showing the diff). The only change I remember was the increase of lag factor of gap motor. If it's look okay to you, please merge it.

@ghalym
Copy link
Collaborator Author

ghalym commented May 13, 2024

Oh yes, the changes were because these axes didn't have independent files. So I fixed it in this PR.

@ghalym ghalym merged commit 6b2dd01 into pcdshub:master May 13, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants