Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: ECS-5151 #119

Merged
merged 2 commits into from
May 8, 2024
Merged

WIP: ECS-5151 #119

merged 2 commits into from
May 8, 2024

Conversation

ghalym
Copy link
Collaborator

@ghalym ghalym commented Apr 25, 2024

changing the pitch scaling factor and limtis accordingly… changing the units on the gap.

https://jira.slac.stanford.edu/browse/ECS-5151

Description

Motivation and Context

How Has This Been Tested?

Where Has This Been Documented?

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@ghalym ghalym requested review from jyotiphy and patoppermann April 25, 2024 18:57
patoppermann
patoppermann approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@patoppermann patoppermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we changed the calibration factor for the exit slit air pitch and changed the the egu and offset for the GAP motor. All locks fine

jyotiphy
jyotiphy approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@jyotiphy jyotiphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ghalym ghalym merged commit 973555b into pcdshub:master May 8, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyotiphy jyotiphy jyotiphy approved these changes

@patoppermann patoppermann patoppermann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghalym @jyotiphy @patoppermann