Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Updated interface with lfe-vac #42

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

ghalym
Copy link
Contributor

@ghalym ghalym commented Jan 16, 2025

Description

Updated interface to lfe-vac from el6692 to el6695

Motivation and Context

A recent update on the lfe-vac to read the status of the txi stopper has been implemented resulting in using t he latest PMPS library. The interface doesn't work on the then installed el6692. An EL6695 was installed on lfe-vac and updated the interface on the arbiter side.

How Has This Been Tested?

Communication is working between both PLCs

Where Has This Been Documented?

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@ghalym ghalym requested a review from ZLLentz January 16, 2025 15:21
<EtherCAT PortABoxInfo="#x01000002"/>
</Box>
<Box File="plc-lfe-gem.xti" Id="34">
<EtherCAT PortABoxInfo="#x0100001a"/>
<EtherCAT PortABoxInfo="#x0100001f"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm somewhat curious about what changed on the gem but not curious enough to try to figure it out

@ZLLentz
Copy link
Member

ZLLentz commented Jan 16, 2025

If it works, there's no reason for me to scrutinize the xml blob so closely

@ghalym ghalym merged commit 050ae1d into pcdshub:master Jan 16, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants