Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Daq Platform rework #99

Merged
merged 9 commits into from
Apr 6, 2018
Merged

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Apr 5, 2018

Description

Concept for doing the daq platform in the yaml file instead of hard-coded in the module. This allows the user to configure the daq platform on a per-host or per-hutch basis.

Motivation and Context

Cxi has 2 daqs

How Has This Been Tested?

I will add tests before the merge

Where Has This Been Documented?

I have updated the docs

@ZLLentz ZLLentz requested a review from teddyrendahl April 5, 2018 18:09
@codecov-io
Copy link

codecov-io commented Apr 5, 2018

Codecov Report

Merging #99 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   97.12%   97.16%   +0.04%     
==========================================
  Files          15       15              
  Lines         695      705      +10     
==========================================
+ Hits          675      685      +10     
  Misses         20       20
Impacted Files Coverage Δ
hutch_python/constants.py 100% <100%> (ø) ⬆️
hutch_python/load_conf.py 98.76% <100%> (+0.09%) ⬆️
hutch_python/daq.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 591eda6...ef9a8e4. Read the comment docs.

@teddyrendahl
Copy link
Contributor

Agreed. This will break MFX if we upgrade without adding the platform default of 4. Not a problem just a note.

@ZLLentz ZLLentz merged commit acdc3ae into pcdshub:master Apr 6, 2018
@ZLLentz ZLLentz deleted the platform-rework branch April 12, 2018 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants